[PATCH] D155884: [Attributor][AMDGPU] Improve indirect call support in closed modules

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:10411
+
+    auto IsValidTypePun = [](Type &T1, Type &T2) {
+      if (&T1 == &T2)
----------------
Move to a separate real function?


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:10416
+        return true;
+      if (T1.isFloatTy() && T2.isFloatTy())
+        return true;
----------------
The float and double cases are covered by T1 == T2?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155884/new/

https://reviews.llvm.org/D155884