[PATCH] D152973: [gold] Add preliminary FatLTO support to the Gold plugin

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 20 13:27:56 PDT 2023


nikic added a comment.

In D152973#4519148 <https://reviews.llvm.org/D152973#4519148>, @paulkirth wrote:

> @tbaeder, could you provide a bit more information about the configuration you are using? The test is in an x86 directory, which should mean it only runs on x86 enabled targets, right? If this is blocking you, I'm OK w/ a revert, but do want to understand what the issue is.

The test requires not only the x86 target in LLVM, but also that ld.gold supports it, which will generally only be the case on x86 hosts. So I think the test needs something like `REQUIRES: x86_64-linux` (not sure if that's the right spelling...).

> @peter.smith thank you for pointing that out. I will be sure to update the documentation.

FYI this change also broke Rust LTO for the same reason (`.llvmbc` used for its own fat LTO equivalent). I expect that can be fixed by switching it to use `.llvm.lto`, but not sure if that will cause any other issues.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152973/new/

https://reviews.llvm.org/D152973



More information about the llvm-commits mailing list