[PATCH] D155257: [llvm-profdata] Changed SampleProfWriter to take a range of of NameFunctionSamples

[David Li via Phabricator via llvm-commits]

davidxl added a comment.

A meta comment -- when the parameter type is change, the name of the parameter should also be changed. In this case 'profileMap' is no longer meaningful.



================
Comment at: llvm/include/llvm/ProfileData/SampleProf.h:1562
 
+  static void flattenProfile(const ArrayRef<NameFunctionSamples> &InputProfiles,
+                             SampleProfileMap &OutputProfiles,
----------------
using template to share code with flattenProfile above?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155257/new/

https://reviews.llvm.org/D155257