[PATCH] D155761: [lld-macho] Use fixed chunk size for UUID

Thu Jul 20 10:38:44 PDT 2023

aaron.ballman added a comment.

In D155761#4519565 <https://reviews.llvm.org/D155761#4519565>, @MaskRay wrote:

> In D155761#4519510 <https://reviews.llvm.org/D155761#4519510>, @aaron.ballman wrote:
>
>> FWIW, I think this may have broken the lld bot for Windows: https://lab.llvm.org/buildbot/#/builders/123/builds/20027
>
> https://lab.llvm.org/buildbot/#/builders/123/builds/20027 is about `lld/test/ELF/export-dynamic-symbol.s`, which is last modified in 2021 by me. The ld.lld (lld/ELF) test is unrelated to lld-macho (lld/MachO).

Oh! Interesting coincidence then. There were a few changes on the blamelist for https://lab.llvm.org/buildbot/#/builders/123/builds/20027 and this was the only one for lld that changed something other than tests. I don't build lld myself, I just noticed the bot went down for the better part of a day and nobody was addressing it.

> Unfortunately I cannot spot anything with the information. Another Windows bot (that I check more frequently) http://45.33.8.238/ is happy with the test.
> Dumping all output from llvm-objdump may help identify the root cause.
>
>   $ "c:\b\slave\clang-x64-windows-msvc\build\stage1\bin\filecheck.exe" "--check-prefix=PLT1" "C:\b\slave\clang-x64-windows-msvc\llvm-project\lld\test\ELF\export-dynamic-symbol.s"
>   # command stderr:
>   C:\b\slave\clang-x64-windows-msvc\llvm-project\lld\test\ELF\export-dynamic-symbol.s:64:9: error: PLT1: expected string not found in input
>   # PLT1: <foo at plt>

Hmm yeah, the arm64 bots are happy with the changes as well.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155761/new/

https://reviews.llvm.org/D155761