[PATCH] D155484: [AArch64] Global Isel Funnel Shift Lowering

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp:866
 
-  getActionDefinitionsBuilder({G_FSHL, G_FSHR}).lower();
+  // getActionDefinitionsBuilder({G_FSHL, G_FSHR}).lower();
+  getActionDefinitionsBuilder({G_FSHL, G_FSHR})
----------------
This an be removed now.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp:1014
+  if (!VRegAndVal){
+    return (Helper.lowerFunnelShiftAsShifts(MI) == LegalizerHelper::LegalizeResult::Legalized);
+  }
----------------
Can you format the patch. Also this doesn't need the (..)  brackets, and single line if's can drop the {..} brackets in llvm.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155484/new/

https://reviews.llvm.org/D155484