[PATCH] D155406: (WIP) [MemCpyOpt] implement multi BB stack-move optimization

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 20 03:33:03 PDT 2023


nikic added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp:1650
+    while (PDom && PDom->isTerminator()) {
+      auto *PostDomBB = (*PDT)[PDom->getParent()]->getIDom()->getBlock();
+      PDom = PostDomBB ? PostDomBB->getFirstNonPHI() : nullptr;
----------------
This looks suspicious to me. Would getBlock() return nullptr, or already getIDom()?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155406/new/

https://reviews.llvm.org/D155406



More information about the llvm-commits mailing list