[PATCH] D155623: [AArch64][NFC] Expand SLEEF coverage for ReplaceWithVeclib testing

Thu Jul 20 03:00:23 PDT 2023

jolanta.jensen added inline comments.

================
Comment at: llvm/test/CodeGen/AArch64/replace-intrinsics-with-veclib-sleef-scalable.ll:6
+
+define <vscale x 2 x double> @llvm_ceil_f64(<vscale x 2 x double> %in) {
+; CHECK-LABEL: @llvm_ceil_f64(
----------------
mgabka wrote:
> jolanta.jensen wrote:
> > mgabka wrote:
> > > the tests in this file are incorrect, the signatures and declarations used for llvm intrinsics are using fixed width type, not a scalable.
> > > 
> > > A comment explaining why the mappings are not used (despite existing in the TLI)  would be also useful.
> > Corrected. Also added vscale to function names.
> > A comment about TLI mappings added.
> I think you are also missing sve attribute either in the RUN line or added to functions, both are acceptable solutions to me.
Added to the RUN line.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155623/new/

https://reviews.llvm.org/D155623