[PATCH] D155306: [mlir][ArmSME] Add tile load op and extend tile store tile size support

Cullen Rhodes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 20 02:50:15 PDT 2023


c-rhodes marked 4 inline comments as done.
c-rhodes added a comment.

In D155306#4517819 <https://reviews.llvm.org/D155306#4517819>, @awarzynski wrote:

> Btw, after reviewing this I feel bad for not adding more roundtrip tests for `arm_sme.store_tile`, so I've created https://reviews.llvm.org/D155800 :) Lets land this one first so that it's your patch that fixes the definition in ArmSME.td 👍🏻 .

You couldn't have added them as only i8 was supported then 😄 I probably should have done that as part of this patch, but thanks for adding them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155306/new/

https://reviews.llvm.org/D155306



More information about the llvm-commits mailing list