[PATCH] D155805: [TableGen][CodeEmitterGen] Emit a default label for getOperandBitOffset()'s OpNum switch

[Ilya Leoshkevich via Phabricator via llvm-commits]

iii created this revision.
iii added reviewers: RKSimon, craig.topper, uweigand.
Herald added a project: All.
iii requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

getOperandBitOffset() causes the following warning on MSVC:

  E:\llvm\ninja\lib\Target\SystemZ\SystemZGenMCCodeEmitter.inc(15414): warning C4060: switch statement contains no 'case' or 'default' labels

Add a default label. An alternative would be to not emit empty OpNum
switches, but this would complicate the code for little benefit.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D155805

Files:
  llvm/utils/TableGen/CodeEmitterGen.cpp


Index: llvm/utils/TableGen/CodeEmitterGen.cpp
===================================================================
--- llvm/utils/TableGen/CodeEmitterGen.cpp
+++ llvm/utils/TableGen/CodeEmitterGen.cpp
@@ -320,6 +320,8 @@
     Success &= addCodeToMergeInOperand(R, BI, std::string(RV.getName()), Case,
                                        BitOffsetCase, Target);
   }
+  BitOffsetCase += "      default:\n";
+  BitOffsetCase += "        break;\n";
   BitOffsetCase += "      }\n";
 
   if (!Success) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155805.542385.patch
Type: text/x-patch
Size: 503 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230720/4b892778/attachment.bin>