[PATCH] D155329: [TableGen][CodeEmitterGen] Add support for querying operand bit offsets

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 20 01:59:38 PDT 2023


RKSimon added a comment.

@iii I'm seeing build warnings (which we treat as errors in most builds) due to this:

  E:\llvm\ninja\lib\Target\SystemZ\SystemZGenMCCodeEmitter.inc(15414): warning C4060: switch statement contains no 'case' or 'default' labels

which came from:

      case SystemZ::CSCH:
      case SystemZ::HSCH:
      case SystemZ::IPK:
      case SystemZ::NNPA:
      case SystemZ::NOP_bare:
      case SystemZ::PALB:
      case SystemZ::PCC:
      case SystemZ::PCKMO:
      case SystemZ::PFPO:
      case SystemZ::PR:
      case SystemZ::PTFF:
      case SystemZ::PTLB:
      case SystemZ::RCHP:
      case SystemZ::RSCH:
      case SystemZ::SAL:
      case SystemZ::SAM24:
      case SystemZ::SAM31:
      case SystemZ::SAM64:
      case SystemZ::SCHM:
      case SystemZ::SCKPF:
      case SystemZ::TAM:
      case SystemZ::TEND:
      case SystemZ::TRAP2:
      case SystemZ::UPT:
      case SystemZ::XSCH: {
        switch (OpNum) {
        }
        break;
      }
    }
    std::string msg;
    raw_string_ostream Msg(msg);
    Msg << "Not supported instr[opcode]: " << MI << "[" << OpNum << "]";
    report_fatal_error(Msg.str().c_str());
  }
  
  #endif // GET_OPERAND_BIT_OFFSET

Please can you update this so that empty case map entries are not emitted?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155329/new/

https://reviews.llvm.org/D155329



More information about the llvm-commits mailing list