[PATCH] D155797: [RISCV] Remove Opcode field from RVInst. Assign Inst{6-0} directly. NFC

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 20 00:59:23 PDT 2023


craig.topper created this revision.
craig.topper added reviewers: asb, wangpc, jrtc27, kito-cheng.
Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, shiva0217, niosHD, sabuasal, simoncook, johnrusso, rbar, hiraditya, arichardson.
Herald added a project: All.
craig.topper requested review of this revision.
Herald added subscribers: eopXD, MaskRay.
Herald added a project: LLVM.

Most places assign Opcode right after assigning every other bit in
Inst. I don't think treating Opcode separately adds much value. It
doesn't hide what bits belong to the opcode since every other bits is
listed.

This makes RVInst consistent with RVInst16 subclasss which already
assign Inst{1-0} directly.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D155797

Files:
  llvm/lib/Target/RISCV/RISCVInstrFormats.td
  llvm/lib/Target/RISCV/RISCVInstrFormatsV.td
  llvm/lib/Target/RISCV/RISCVInstrInfoXCV.td
  llvm/lib/Target/RISCV/RISCVInstrInfoXSf.td
  llvm/lib/Target/RISCV/RISCVInstrInfoXTHead.td
  llvm/lib/Target/RISCV/RISCVInstrInfoZfa.td
  llvm/lib/Target/RISCV/RISCVInstrInfoZvk.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155797.542347.patch
Type: text/x-patch
Size: 12057 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230720/aa818414/attachment.bin>


More information about the llvm-commits mailing list