[PATCH] D155789: [Support] Implement LLVM_ENABLE_REVERSE_ITERATION for StringMap

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 20 00:51:49 PDT 2023


MaskRay added a subscriber: RKSimon.
MaskRay added a comment.

Thank you for favoring this patch:) You may notice that I have reported issues to two patches and I'd like them to be addressed first. At the very least I have to wait for the unit test from D149162 <https://reviews.llvm.org/D149162> to be fixed as it cannot be worked around by `UNSUPPORTED: reverse_iteration`.

For the documentation, I am thinking of

  **LLVM_ENABLE_REVERSE_ITERATION**:BOOL
    Some set-like containers (e.g., DenseMap, StringMap) have unspecified iteration order. Reverse the iteration order for them to catch accidental reliance. Defaults to OFF.

near  `LLVM_ENABLE_EXPENSIVE_CHECKS` commit 0aa27cd29ba3f2cf98b1f48bc6e653d8a66630e8 (@RKSimon) for


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155789/new/

https://reviews.llvm.org/D155789



More information about the llvm-commits mailing list