[PATCH] D155626: [DAG][AArch64] Fix truncated vscale constant types

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 20 00:01:56 PDT 2023

sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

In D155626#4516126 <https://reviews.llvm.org/D155626#4516126>, @dmgreen wrote:

> I was thinking about it, and I think it would be better to not be sloppy about the APInt passed to getVScale. Similar to existing methods in DAG like getConstant, we should be asserting that the size of the APInt and the type match. Otherwise it should be up to the caller to make them match in a way that is appropriate.
> It appears from looking through the calls to getVScale that the version in getNode when truncating the value is the only one where they can be a mismatch.

That makes sense. I thought there would have been more instances that needed fixing, but glad to see that wasn't the case.



More information about the llvm-commits mailing list