[PATCH] D143539: [AMDGPU] Add AMDGPU support for llvm-objcopy

Wed Jul 19 23:55:03 PDT 2023

jhenderson added a comment.

Sorry, I was away last week and am still catching up since then.

Is there a reason you haven't just added the new amdgpu case to the existing cross-arch-headers.test file? That seems to me like where it should belong.

================
Comment at: llvm/tools/llvm-objcopy/ObjcopyOptions.cpp:305-306
     // Name, {EMachine, 64bit, LittleEndian}
+    // AMDGPU
+    {"elf64-amdgpu", {ELF::EM_AMDGPU, true, true}},
     // x86
----------------
I would suggest that this be moved to the end of the list, purely on the basis that the list has no specific ordering, and newer targets tend to be added at the end.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143539/new/

https://reviews.llvm.org/D143539