[PATCH] D138135: [lld][ELF] Support LoongArch

Wed Jul 19 23:41:48 PDT 2023

xry111 added a comment.

In D138135#4517125 <https://reviews.llvm.org/D138135#4517125>, @xen0n wrote:

> In D138135#4517120 <https://reviews.llvm.org/D138135#4517120>, @MaskRay wrote:
>
>> In D138135#4517087 <https://reviews.llvm.org/D138135#4517087>, @xen0n wrote:
>>
>>> Friendly ping; ideally I'd like this port to get included in LLVM 17, which will vastly simplify things ecosystem-wide, such as ClangBuiltLinux testing, Gentoo LLVM stagebuilding, and possibly many more large projects depending on lld.
>>
>> This is on my radar and I will take a look again soon. There are also random other LoongArch things I need to take a look and I did. This is totally fine to be cherry picked into the `release/17.x` branch even after it is created.
>> I am sorry that I did not respond in time for the initial period of the patch (when it changed from the "WIP" state to the normal in-review state), but I think the request after 3 days may be a bit too quick.
>> Honestly the linker is probably I care about the most and I don't want to lower the bar. (There are other things that I am concerned with as well, but I may not have too much energy to prevent something less appropriate happen; but if I notice, I'll make a comment).
>
> Thanks for the clarification. I didn't know if the release branch cherry-pick could be done in this case so I was a little anxious, sorry for the less-than-a-week ping.
>
> I fully understand your passion and care for the linker and I agree with not lowering the bar; I'll do my best to improve the code together.

After being disgusted by the code of [another linker] multiple times I now totally agree we must be careful when we write a linker...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138135/new/

https://reviews.llvm.org/D138135