[PATCH] D155734: [X86][AArch64] Add additional extract_lowbits test
Danila Malyutin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 19 23:17:19 PDT 2023
danilaml added a comment.
In D155734#4516890 <https://reviews.llvm.org/D155734#4516890>, @pengfei wrote:
> LGTM. If possible, you could add new test on the end of the file, so that you won't get a lot of BB number changes.
I just the felt that it logically fits better right after the test it was based on (and it's easier to confirm that the asm doesn't change for non-bzhi case that way). I feel like update_llc_test_checks should be able to do something with labels, since their name is usually not important, but it doesn't seem like it does currently.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155734/new/
https://reviews.llvm.org/D155734
More information about the llvm-commits
mailing list