[PATCH] D153066: [AppleTables] Implement iterator over all entries in table
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 19 19:49:02 PDT 2023
MaskRay added inline comments.
================
Comment at: llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp:466
+ std::function<StringRef(uint64_t RegNum, bool IsEH)> GetNameForDWARFReg) {
+ StringMap<llvm::SmallSet<DWARFDie, 2>> NameToDies;
+
----------------
This relies on the iteration order of StringMap and SmallSet, which is not good. I'll fix this to use MapVector.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153066/new/
https://reviews.llvm.org/D153066
More information about the llvm-commits
mailing list