[PATCH] D146778: [lld] Preliminary fat-lto-object support

[NAKAMURA Takumi via Phabricator via llvm-commits]

chapuni added inline comments.


================
Comment at: lld/test/ELF/fatlto/fatlto.invalid.s:1
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t
+# RUN: not ld.lld %t -o /dev/null --fat-lto-objects 2>&1 | FileCheck %s
----------------
This should be suppressed, too.


================
Comment at: lld/test/ELF/fatlto/fatlto.test:54
+target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
----------------
paulkirth wrote:
> chapuni wrote:
> > Should this test be suppressed if x86 is uncofigred?
> Doesn’t this test have a requires x86 line?
Sorry, this has required x86. `fatlto.invalid.s` doesn't.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146778/new/

https://reviews.llvm.org/D146778