[PATCH] D155763: [BOLT][DWARF][NFC] Fix performance regression

[Alexander Yermolovich via Phabricator via llvm-commits]

ayermolo created this revision.
Herald added subscribers: treapster, hoy, modimo, wenlei.
Herald added a reviewer: rafauler.
Herald added a reviewer: Amir.
Herald added a reviewer: maksfb.
Herald added a project: All.
ayermolo requested review of this revision.
Herald added subscribers: llvm-commits, yota9.
Herald added a project: LLVM.

In one of the previous diffs this was changed to pass by value. This lead to
performance regression for binaries with DWARF4 split dwarf.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D155763

Files:
  bolt/lib/Core/DebugData.cpp


Index: bolt/lib/Core/DebugData.cpp
===================================================================
--- bolt/lib/Core/DebugData.cpp
+++ bolt/lib/Core/DebugData.cpp
@@ -651,7 +651,7 @@
                                DebugLocationsVector &LocList,
                                DIEBuilder &DIEBldr, DIE &Die,
                                DebugAddrWriter &AddrWriter,
-                               DebugBufferVector LocBuffer, DWARFUnit &CU,
+                               DebugBufferVector &LocBuffer, DWARFUnit &CU,
                                raw_svector_ostream &LocStream) {
   if (LocList.empty()) {
     replaceLocValbyForm(DIEBldr, Die, AttrInfo, AttrInfo.getForm(),


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155763.542239.patch
Type: text/x-patch
Size: 688 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230719/d4137d3e/attachment.bin>