[PATCH] D155420: [PostDom] add findNearestCommonDominator for instructions

Wed Jul 19 16:14:50 PDT 2023

khei4 abandoned this revision.
khei4 added a comment.

> I think I would prefer to add this as a local helper to MemCpyOpt until we have a second use case.

It seems reasonable! I'll move this to https://reviews.llvm.org/D155406 ;)

================
Comment at: llvm/include/llvm/Analysis/PostDominators.h:49
+  /// Find the nearest instruction I that post-dominates both I1 and I2, in the
+  /// sense that a result produced after I will be available at both I1 and I2.
+  Instruction *findNearestCommonDominator(Instruction *I1,
----------------
nikic wrote:
> The "in the sense" part isn't correct for post-dominators.
Thanks! I'll fix it on the https://reviews.llvm.org/D155406.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155420/new/

https://reviews.llvm.org/D155420