[PATCH] D155734: [X86][AArch64] Add additional extract_lowbits test
Noah Goldstein via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 19 13:35:44 PDT 2023
goldstein.w.n added a comment.
Your change is x86 only. Why are you adding aarch64 tests?
Also you have the order flipped around. The test commit should be the child of the implementation, not the other way around.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155734/new/
https://reviews.llvm.org/D155734
More information about the llvm-commits
mailing list