[PATCH] D146778: [lld] Preliminary fat-lto-object support

Wed Jul 19 13:33:41 PDT 2023

MaskRay added a comment.

In D146778#4516124 <https://reviews.llvm.org/D146778#4516124>, @paulkirth wrote:

> @MaskRay the CI failures here and in D152973 <https://reviews.llvm.org/D152973> seem unrelated to the FatLTO patches (e.g. MLIR + windows).
>
> Are we good w/ landing the linker support for LLD + gold now, or would you prefer that I rebase these and get the premerge checks passing first?

You may land this patch after fixing a "Support" nit for the release note. I have applied this patch and `check-lld-elf` passes.

You can also land the gold patch. Pre-commit build bots don't seem to check binutils. You'll need a local checkout of binutils-gdb, e.g. `-DLLVM_BINUTILS_INCDIR=$HOME/Dev/binutils-gdb/include`.

================
Comment at: lld/docs/ReleaseNotes.rst:34

+- Support LTO with LLVM FatLTO objects by adding the `-fat-lto-objects` flag.
+  Without `-fat-lto-objects`, LLD will link Fat LTO objects without LTO.
----------------
MaskRay wrote:
> MaskRay wrote:
> > Double backsticks. Prefer `option` over `flag` especially for linkers.
> > ``--fat-lto-objects`` option is added to support LLVM FatLTO.
Support should not be capitalized.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146778/new/

https://reviews.llvm.org/D146778