[PATCH] D153907: [AIX] [TOC] Add -mtocdata/-mno-tocdata options on AIX

[Chris Bowler via Phabricator via llvm-commits]

cebowleratibm added inline comments.


================
Comment at: lib/CodeGen/Targets/PPC.cpp:274
+  if (auto *GVar = dyn_cast<llvm::GlobalVariable>(GV)) {
+    auto GVId = GVar->getGlobalIdentifier();
+
----------------
@hubert.reinterpretcast and I were discussing whether or not this query is the right query to use because you're string comparing the value against a string provided by the user on the command line.  I think it's probably safer to use a well-defined linkage name for the comparison and set it up such that we don't unnecessarily compute it unless the toc-data feature is opted into.

We should discuss offline and update this thread with our conclusion.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153907/new/

https://reviews.llvm.org/D153907