[PATCH] D155622: [X86] Recognize standalone `(1 << nbits) - 1` pattern as bzhi

Danila Malyutin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 19 11:09:57 PDT 2023

danilaml marked an inline comment as done.
danilaml added inline comments.

Comment at: llvm/test/CodeGen/X86/extract-lowbits.ll:516
+; X86-BMI2-NEXT:    retl
 ; X64-NOBMI-LABEL: bzhi64_a1_indexzext:
danilaml wrote:
> goldstein.w.n wrote:
> > Can you split the new tests to a seperate patch?
> > 
> > I.e 
> > commit 1: tests (updated with LLVM before this commit)
> > commit 2: impl (update tests with the impl)
> > 
> > Then submit both to phab and use "Edit Related Revisions" to make the tests patch the child of the impl patch.
> > 
> > That way it easier to track the changes caused by the impl itself.
> commit 1 would be empty in this case. Everything below this line is just label renumbering caused by insertion of the new test function.
Disregard previous reply. Phabricator is being unwieldy. Tests are now in https://reviews.llvm.org/D155734

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list