[PATCH] D155622: [X86] Recognize standalone `(1 << nbits) - 1` pattern as bzhi

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added inline comments.


================
Comment at: llvm/test/CodeGen/X86/extract-lowbits.ll:516
+; X86-BMI2-NEXT:    retl
+;
 ; X64-NOBMI-LABEL: bzhi64_a1_indexzext:
----------------
Can you split the new tests to a seperate patch?

I.e 
commit 1: tests (updated with LLVM before this commit)
commit 2: impl (update tests with the impl)

Then submit both to phab and use "Edit Related Revisions" to make the tests patch the child of the impl patch.

That way it easier to track the changes caused by the impl itself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155622/new/

https://reviews.llvm.org/D155622