[PATCH] D155723: [DWARFVerifier] Allow simplified template names in debug_name

[Alexey Lapshin via Phabricator via llvm-commits]

avl accepted this revision.
avl added a comment.

LGTM, with small suggestions inside.



================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp:1354
 
 static SmallVector<StringRef, 2> getNames(const DWARFDie &DIE,
+                                          bool IncludeStrippedTemplateNames,
----------------
probably use 3 here as initial size? As it may return three names now.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp:1363
+              StripTemplateParameters(Result.back()))
+        Result.push_back(*StrippedName);
+    }
----------------
nit: other places use emplace_back.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155723/new/

https://reviews.llvm.org/D155723