[PATCH] D155684: [XCOFF] Write source language ID and CPU version ID into C_FILE symbol.

Stephen Peckham via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 19 10:20:57 PDT 2023


stephenpeckham added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:1125
+
     writeSymbolEntry(F.first, /*Value=*/0, XCOFF::ReservedSectionNum::N_DEBUG,
+                     /*SymbolType=*/(LangID << 8) | CpuID, XCOFF::C_FILE,
----------------
You could use FileName instead of F.first.

By the way, the system assembler generates a C_FILE symbol  with auxiliary symbol table entries, allowing the compiler version and timestamp to be specified. (That might need a separate patch.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155684/new/

https://reviews.llvm.org/D155684



More information about the llvm-commits mailing list