[PATCH] D155329: [TableGen][CodeEmitterGen] Add support for querying operand bit offsets

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 19 09:37:44 PDT 2023


uweigand added a comment.

The SystemZ parts LGTM.     The TableGen changes also look reasonable to me, but I'd also like to wait for Craig's input on whether his concerns are resolved with this version.

It would be good to have a comment spelling out the explicit semantics of the new `getOperandBitOffset` routine that targets can rely on.  Maybe the top of `CodeEmitterGen.cpp` would be a good place for this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155329/new/

https://reviews.llvm.org/D155329



More information about the llvm-commits mailing list