[PATCH] D154812: [Support] Add llvm::xxh3_64bits

Wed Jul 19 09:01:47 PDT 2023

MaskRay added a comment.

In D154812#4514078 <https://reviews.llvm.org/D154812#4514078>, @andrewng wrote:

>>> I haven't looked at the code but I have built `ld.lld` with this patch and the patch from D154813 <https://reviews.llvm.org/D154813> on Windows with both VS 2022 `cl` 19.36.32537 and `clang-cl` 16.0.6. I have run the usual benchmarks (clang, chrome, mozilla, scylla) and also a UE5 link and I don't see any difference in performance on my Windows 10 PC, i.e. any delta is in the measurement "noise".
>>
>> Thank you for benchmarking this on Windows. Do these programs have large `.debug_str` sections? (Windows builds normally use CodeView/PDB, not DWARF).
>> I think only any effect is likely only observed with large `.debug_str` sections. To observe the effect of replacing the hash function, I need to compute the time ratio of hashing
>
> The tests that I ran were all ELF links and one of the `clang` links included DWARF debug.
>
> Out of interest, which compiler did you use to build your Linux `lld`?

I use a close-to-trunk prebuilt Clang from Chromium: `curl -s https://raw.githubusercontent.com/chromium/chromium/main/tools/clang/scripts/update.py | python3 - --output-dir=~/Stable`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154812/new/

https://reviews.llvm.org/D154812