[PATCH] D153907: [AIX] [TOC] Add -mtocdata/-mno-tocdata options on AIX

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: clang/lib/CodeGen/Targets/PPC.cpp:274
+  if (auto *GVar = dyn_cast<llvm::GlobalVariable>(GV)) {
+    auto GVId = GVar->getGlobalIdentifier();
+
----------------
This use of `getGlobalIdentifier` (having a user-interface that relies on its format) seems novel. It warrants updating the Doxygen description of the function.

I believe some discussion should be had on LLVM Discourse about this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153907/new/

https://reviews.llvm.org/D153907