[PATCH] D154725: [AggressiveInstCombine] Fold strcmp for short string literals

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

Done! Please follow https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access for requesting commit access.



================
Comment at: llvm/lib/Transforms/AggressiveInstCombine/AggressiveInstCombine.cpp:907
+  return false;
+}
+
----------------
goldstein.w.n wrote:
> kitaisreal wrote:
> > goldstein.w.n wrote:
> > > should the sqrt patch be split into a preliminary NFC?
> > Do you propose to extract most of the changes from `AggressiveInstCombine`, that are not related to `expandStrcmp` in separate patch ?
> Yeah, but this has already been approved, so no need to make it a blocker.
Yeah, this would have been a bit nicer, to make it clear that this doesn't really change anything about the sqrt fold, just moves code around.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154725/new/

https://reviews.llvm.org/D154725