[PATCH] D155617: [WIP] GSoC 2023: Pass to annotate functions with appropriate optimization level.

Puneeth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 19 07:33:18 PDT 2023


Puneeth-A-R marked an inline comment as done.
Puneeth-A-R added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/FunctionAnnotator.cpp:42
+  std::string Line;
+  for (Function &F : M) {
+    while (std::getline(CSVFile, Line)) {
----------------
mtrofin wrote:
> nit: `const Function &F`
Turns out, there isn't an overload of `Function` that has `addFnAttr` function in it. So that can't be made a `const`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155617/new/

https://reviews.llvm.org/D155617



More information about the llvm-commits mailing list