[PATCH] D154052: Refactor some BasicBlockUtils functions (NFC)

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 19 07:19:18 PDT 2023


dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

Thanks LGTM



================
Comment at: llvm/lib/Transforms/Utils/BasicBlockUtils.cpp:1526
+
+  // Encapsulat the logic around creation/insertion/etc of a new block.
+  auto handleBlock = [&](BasicBlock **PBB, bool Unreachable, BasicBlock *&BB,
----------------
Encapsulate


================
Comment at: llvm/lib/Transforms/Utils/BasicBlockUtils.cpp:1530
+    if (PBB == nullptr)
+      return; // do not create/insert a block
+
----------------
do -> Do


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154052/new/

https://reviews.llvm.org/D154052



More information about the llvm-commits mailing list