[PATCH] D153907: [AIX] [TOC] Add -mtocdata/-mno-tocdata options on AIX

Wed Jul 19 07:11:00 PDT 2023

cebowleratibm added inline comments.

================
Comment at: clang/test/CodeGen/PowerPC/toc-data-attribute.c:44
+// CHECK32-NOT: @g = global i64 5, align 8 #0
+// CHECK32-NOT: @j = global i32 0, align 128 #0
+// CHECK32-NOT: @l = global double 2.500000e+00, align 8 #0
----------------
You expect to see `j` in the IR, just that it shouldn't have the toc-data attribute.  Perhaps it's better to check the positive (with the #0 omitted) because the check-not may be satisfied if there is a subtle change in how `j` is emitted.  This comment applies to multiple instances.

================
Comment at: clang/test/Driver/toc-conf.c:15
+// CHECK-EQCONF-NOT: warning:
+// CHECK-EQCONF: "-mno-tocdata"
+// CHECK-EQCONF: "-mtocdata=g3,g4"
----------------
I assume you're checking that the `-mno-tocdata` property is passed on the cc1 invocation.  This would read better if the `cc1` were part of the match.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153907/new/

https://reviews.llvm.org/D153907