[PATCH] D155699: [AMDGPU] Allow vector access types in PromoteAllocaToVector
Nuno Lopes via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 19 06:35:46 PDT 2023
nlopes added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp:427
+ } else {
+ SubVec = UndefValue::get(SubVecTy);
+ for (unsigned K = 0; K < NumElts; ++K) {
----------------
Please use poison instead of undef as a placeholder whenever possible (like here).
We are trying to remove undef. Thank you!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155699/new/
https://reviews.llvm.org/D155699
More information about the llvm-commits
mailing list