[PATCH] D151547: [RISCV] Remove experimental for zihintntl.
Piyou Chen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 19 04:49:26 PDT 2023
BeMg added inline comments.
================
Comment at: llvm/unittests/Support/RISCVISAInfoTest.cpp:376
EXPECT_EQ(Exts.count("zihintntl"), 1U);
- auto MaybeISAInfo2 = RISCVISAInfo::parseArchString("rv64izihintntl0p2", true);
+ auto MaybeISAInfo2 = RISCVISAInfo::parseArchString("rv64izihintntl1p0", true);
ASSERT_THAT_EXPECTED(MaybeISAInfo2, Succeeded());
----------------
These unit tests are used to test the experimental extension name parsing, it is not suitable to use zihintntl here because zihintntl is no longer experimental.
I update it by https://reviews.llvm.org/D155673. After rebasing, I think the test fail in RISCVISAInfoTest.cpp can be resolved.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151547/new/
https://reviews.llvm.org/D151547
More information about the llvm-commits
mailing list