[PATCH] D155594: [InstCombine][NFC] Add tests for preserving metadata

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/select_meta.ll:397
 ; CHECK-NEXT: !1 = !{!"branch_weights", i32 10, i32 2}
-
+; CHECK-NEXT: !2 = !{}
----------------
chfast wrote:
> nikic wrote:
> > It would be better to run update_test_checks.py with `--check-globals` option so these get auto-generated.
> I updated tests with `--check-globals` and removed "enhancement to include metadata checking." Does it look good?
Yes, looks good!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155594/new/

https://reviews.llvm.org/D155594