[PATCH] D155623: [AArch64][NFC] Expand SLEEF coverage for ReplaceWithVeclib testing

Jolanta Jensen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 19 04:46:40 PDT 2023


jolanta.jensen added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/replace-intrinsics-with-veclib-sleef-scalable.ll:6
+
+define <vscale x 2 x double> @llvm_ceil_f64(<vscale x 2 x double> %in) {
+; CHECK-LABEL: @llvm_ceil_f64(
----------------
mgabka wrote:
> the tests in this file are incorrect, the signatures and declarations used for llvm intrinsics are using fixed width type, not a scalable.
> 
> A comment explaining why the mappings are not used (despite existing in the TLI)  would be also useful.
Corrected. Also added vscale to function names.
A comment about TLI mappings added.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155623/new/

https://reviews.llvm.org/D155623



More information about the llvm-commits mailing list