[PATCH] D154695: [Coroutines] Add an O(n) algorithm for computing the cross suspend point information.

Wed Jul 19 03:31:36 PDT 2023

ChuanqiXu added a comment.

In D154695#4514133 <https://reviews.llvm.org/D154695#4514133>, @witstorm95 wrote:

> @ChuanqiXu Thanks for your comments. I will improve it.
>
>> IIUC, for.cond.Kills[Entry] should be true since there is a path from Entry to for.cond without repeating Entry, right?
>
> The definition about Kill is,
>
>   //   Kills: a bit vector which contains a set of indices of blocks that can                                                                                                                                                                     
>   //          reach block 'i' but there is a path crossing a suspend point                                                                                                                                                                       
>   //          not repeating 'i' (path to 'i' without cycles containing 'i'). 
>   }
>
> So  for.cond.Kills[Entry]  means whether exists a path from Entry to for.cond crossing a suspend point not repeating for.cond.

Oh, you're right. There are some problems about the definitions. Let's correct it in other patches.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154695/new/

https://reviews.llvm.org/D154695