[PATCH] D153911: [cmake] Add -Wcast-qual to C flags if LLVM_ENABLE_WARNINGS is defined.

Wed Jul 19 03:18:21 PDT 2023

hctim added a comment.

Hi, we're still seeing sanitizer buildbot failures from what I assume is this patch.

https://lab.llvm.org/buildbot/#/builders/37/builds/23724

  /b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/lib/profile/InstrProfilingValue.c:62:17: error: cast from 'const unsigned short *' to 'unsigned short *' drops const qualifier [-Werror,-Wcast-qual]
     62 |   *((uint16_t *)&Data->NumValueSites[ValueKind]) = NumValueSites;

Maybe it's worth reverting, doing the cleanup, and then re-submitting rather than trying to fix-forward? It would appear if there's a lot of cleanup required.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153911/new/

https://reviews.llvm.org/D153911