[PATCH] D155594: [InstCombine][NFC] Add tests for preserving !unreachable

[Paweł Bylica via Phabricator via llvm-commits]

chfast updated this revision to Diff 541925.
chfast added a comment.

Focus on select+binop, add more test cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155594/new/

https://reviews.llvm.org/D155594

Files:
  llvm/test/Transforms/InstCombine/select_meta.ll


Index: llvm/test/Transforms/InstCombine/select_meta.ll
===================================================================
--- llvm/test/Transforms/InstCombine/select_meta.ll
+++ llvm/test/Transforms/InstCombine/select_meta.ll
@@ -64,8 +64,8 @@
 
 define i64 @test43(i32 %a) nounwind {
 ; CHECK-LABEL: @test43(
-; CHECK-NEXT:    [[TMP1:%.*]] = call i32 @llvm.smax.i32(i32 [[A:%.*]], i32 0)
-; CHECK-NEXT:    [[MAX:%.*]] = zext i32 [[TMP1]] to i64
+; CHECK-NEXT:    [[NARROW:%.*]] = call i32 @llvm.smax.i32(i32 [[A:%.*]], i32 0)
+; CHECK-NEXT:    [[MAX:%.*]] = zext i32 [[NARROW]] to i64
 ; CHECK-NEXT:    ret i64 [[MAX]]
 ;
   %a_ext = sext i32 %a to i64
@@ -316,10 +316,82 @@
   ret <2 x i32> %r
 }
 
+; TODO: The metadata should be preserved.
+define i64 @select_add(i1 %cond, i64 %x, i64 %y) {
+; CHECK-LABEL: @select_add(
+; CHECK-NEXT:    [[OP:%.*]] = select i1 [[COND:%.*]], i64 [[Y:%.*]], i64 0
+; CHECK-NEXT:    [[RET:%.*]] = add i64 [[OP]], [[X:%.*]]
+; CHECK-NEXT:    ret i64 [[RET]]
+;
+  %op = add i64 %x, %y
+  %ret = select i1 %cond, i64 %op, i64 %x, !prof !1, !unpredictable !3
+  ret i64 %ret
+}
+
+; TODO: The metadata should be preserved.
+define <2 x i32> @select_or(<2 x i1> %cond, <2 x i32> %x, <2 x i32> %y) {
+; CHECK-LABEL: @select_or(
+; CHECK-NEXT:    [[OP:%.*]] = select <2 x i1> [[COND:%.*]], <2 x i32> [[Y:%.*]], <2 x i32> zeroinitializer
+; CHECK-NEXT:    [[RET:%.*]] = or <2 x i32> [[OP]], [[X:%.*]]
+; CHECK-NEXT:    ret <2 x i32> [[RET]]
+;
+  %op = or <2 x i32> %x, %y
+  %ret = select <2 x i1> %cond, <2 x i32> %op, <2 x i32> %x, !prof !1, !unpredictable !3
+  ret <2 x i32> %ret
+}
+
+; TODO: The metadata should be preserved.
+define i17 @select_sub(i1 %cond, i17 %x, i17 %y) {
+; CHECK-LABEL: @select_sub(
+; CHECK-NEXT:    [[OP:%.*]] = select i1 [[COND:%.*]], i17 [[Y:%.*]], i17 0
+; CHECK-NEXT:    [[RET:%.*]] = sub i17 [[X:%.*]], [[OP]]
+; CHECK-NEXT:    ret i17 [[RET]]
+;
+  %op = sub i17 %x, %y
+  %ret = select i1 %cond, i17 %op, i17 %x, !prof !1, !unpredictable !3
+  ret i17 %ret
+}
+
+; TODO: The metadata should be preserved.
+define i128 @select_ashr(i1 %cond, i128 %x, i128 %y) {
+; CHECK-LABEL: @select_ashr(
+; CHECK-NEXT:    [[OP:%.*]] = select i1 [[COND:%.*]], i128 [[Y:%.*]], i128 0
+; CHECK-NEXT:    [[RET:%.*]] = ashr i128 [[X:%.*]], [[OP]]
+; CHECK-NEXT:    ret i128 [[RET]]
+;
+  %op = ashr i128 %x, %y
+  %ret = select i1 %cond, i128 %op, i128 %x, !prof !1, !unpredictable !3
+  ret i128 %ret
+}
+
+; TODO: The metadata should be preserved.
+define double @select_fmul(i1 %cond, double %x, double %y) {
+; CHECK-LABEL: @select_fmul(
+; CHECK-NEXT:    [[OP:%.*]] = select i1 [[COND:%.*]], double [[Y:%.*]], double 1.000000e+00
+; CHECK-NEXT:    [[RET:%.*]] = fmul double [[OP]], [[X:%.*]]
+; CHECK-NEXT:    ret double [[RET]]
+;
+  %op = fmul double %x, %y
+  %ret = select i1 %cond, double %op, double %x, !prof !1, !unpredictable !3
+  ret double %ret
+}
+
+; TODO: The metadata should be preserved.
+define <2 x float> @select_fdiv(i1 %cond, <2 x float> %x, <2 x float> %y) {
+; CHECK-LABEL: @select_fdiv(
+; CHECK-NEXT:    [[OP:%.*]] = select i1 [[COND:%.*]], <2 x float> [[Y:%.*]], <2 x float> <float 1.000000e+00, float 1.000000e+00>
+; CHECK-NEXT:    [[RET:%.*]] = fdiv <2 x float> [[X:%.*]], [[OP]]
+; CHECK-NEXT:    ret <2 x float> [[RET]]
+;
+  %op = fdiv <2 x float> %x, %y
+  %ret = select i1 %cond, <2 x float> %op, <2 x float> %x, !prof !1, !unpredictable !3
+  ret <2 x float> %ret
+}
 
 !1 = !{!"branch_weights", i32 2, i32 10}
 !2 = !{!"branch_weights", i32 3, i32 10}
+!3 = !{}
 
 ; CHECK:      !0 = !{!"branch_weights", i32 2, i32 10}
 ; CHECK-NEXT: !1 = !{!"branch_weights", i32 10, i32 2}
-
+; CHECK-NEXT: !2 = !{}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155594.541925.patch
Type: text/x-patch
Size: 3696 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230719/2b0765a6/attachment.bin>