[PATCH] D153936: [LV] Add tests for select-cmp reduction pattern. (NFC)

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.

LGTM, thanks!



================
Comment at: llvm/test/Transforms/LoopVectorize/iv-select-cmp.ll:35
+for.body:                                         ; preds = %entry, %for.body
+  %i.010 = phi i64 [ %inc, %for.body ], [ 0, %entry ]
+  %rdx.09 = phi i64 [ %cond, %for.body ], [ 3, %entry ]
----------------
nit: can also drop `.010` and `.09` from the value names


================
Comment at: llvm/test/Transforms/LoopVectorize/iv-select-cmp.ll:49
+
+define i64 @select_icmp_const_3(ptr nocapture readonly %a, i64 %ii, i64 %n) {
+; CHECK-LABEL: define i64 @select_icmp_const_3
----------------
nit: would `select_icmp_const_3-> select_icmp_const_3_variable_rdx_start` be more descriptive?


================
Comment at: llvm/test/Transforms/LoopVectorize/iv-select-cmp.ll:115
+
+define i64 @select_icmp(ptr nocapture readonly %a, ptr nocapture readonly %b, i64 %ii, i64 %n) {
+; CHECK-LABEL: define i64 @select_icmp
----------------
nit: `ii` better named `rdx.start` or something like that

nit: would `@select_icmp` -> `@select_icmp_variable_rdx_start` be more descriptive?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153936/new/

https://reviews.llvm.org/D153936