[PATCH] D155681: [AMDGPU] Insert s_nop before s_sendmsg sendmsg(MSG_DEALLOC_VGPRS)

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

In D155681#4513934 <https://reviews.llvm.org/D155681#4513934>, @foad wrote:

> In D155681#4513861 <https://reviews.llvm.org/D155681#4513861>, @rampitec wrote:
>
>> Do you want to guard it with a predicate? I assume this will be fixed one day.
>>
>> I.e. a subtarget check would make sense to me. Not a feature, just a check in the subtarget.
>
> I thought I would only do that when we get a new subtarget where this is not required. I could leave a TODO until then.

Still I would do a stub predicate returning true. As one of our colleagues said: this is not my first rodeo.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155681/new/

https://reviews.llvm.org/D155681