[PATCH] D155571: [MemCpyOpt] add terminator user test for D153453(NFC)

Kohei Asano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 19 02:08:36 PDT 2023


khei4 added a comment.

@nikic Thank you for the review!



================
Comment at: llvm/test/Transforms/MemCpyOpt/stack-move.ll:417
+
+  %2 = call i32 @use_nocapture(ptr nocapture %dest)
+  call void @llvm.lifetime.end.p0(i64 12, ptr %src)
----------------
nikic wrote:
> Is this call needed to reproduce the crash?
No, just some copy source residue noise! Thanks! 


================
Comment at: llvm/test/Transforms/MemCpyOpt/stack-move.ll:423
+  %lp = landingpad i32 cleanup
+  br label %ehcleanup
+ehcleanup:
----------------
nikic wrote:
> I don't think this extra br is needed, you can directly resume.
Right!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155571/new/

https://reviews.llvm.org/D155571



More information about the llvm-commits mailing list