[PATCH] D155556: [GlobalISel] GIntrinsic subclass to represent intrinsics in Generic Machine IR

[Sameer Sahasrabuddhe via Phabricator via llvm-commits]

sameerds marked 2 inline comments as done.
sameerds added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MachineInstr.h:1944
+  /// Returns Intrinsic::ID if this is an intrinsic, else returns not_intrinsic.
   unsigned getIntrinsicID() const {
+    if (!isIntrinsic())
----------------
arsenm wrote:
> sameerds wrote:
> > @arsenm, do you see any value in introducing `GIntrinsic` as a subclass of `GenericMachineInstr` and moving `getIntrinsicID()` to it? I tried half of that in D154766, but I don't see any real advantage. I am thinking I'll roll it back in D154766.
> We should probably do it and make more use of GenericMachineInstr
Added the new `GIntrinsic` class and updated the review description.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155556/new/

https://reviews.llvm.org/D155556