[PATCH] D155662: [X86] Promote VAES implied feature to AVX2

Freddy, Ye via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 18 19:39:32 PDT 2023


FreddyYe added inline comments.


================
Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:614
 constexpr FeatureBitset ImpliedFeaturesSHA = FeatureSSE2;
-constexpr FeatureBitset ImpliedFeaturesVAES = FeatureAES | FeatureAVX;
+constexpr FeatureBitset ImpliedFeaturesVAES = FeatureAES | FeatureAVX2;
 constexpr FeatureBitset ImpliedFeaturesVPCLMULQDQ = FeatureAVX | FeaturePCLMUL;
----------------
skan wrote:
> If so ,shouldn't we update X86.td too?
Oh yes! Forgot!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155662/new/

https://reviews.llvm.org/D155662



More information about the llvm-commits mailing list