[PATCH] D154638: Emit a .debug_addr section with dsymutil

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/DWARFLinker/DWARFLinker.cpp:1398
+
+  assert((AttrSpec.Form == dwarf::DW_FORM_addrx) ||
+         (AttrSpec.Form == dwarf::DW_FORM_addrx1 &&
----------------
This is the first time I'm reading through the patch, so I might be missing something: Since the address pool is growing as we are processing multiple object files, shouldn't we dynamically decide on the FORM based on the value of `AddrIndex`? Or is this happening elsewhere already?


================
Comment at: llvm/lib/DWARFLinker/DWARFStreamer.cpp:619
+
+  // emit length.
+  Asm->emitLabelDifference(EndLabel, BeginLabel, sizeof(uint32_t));
----------------
Nit: `Emit`


================
Comment at: llvm/lib/DWARFLinker/DWARFStreamer.cpp:624
+
+  // emit version
+  Asm->emitInt16(5);
----------------
`Emit version.`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154638/new/

https://reviews.llvm.org/D154638