[PATCH] D153963: [InstCombine] Fold binop of select and cast of select condition

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 18 15:50:48 PDT 2023


goldstein.w.n added a comment.

In D153963#4511653 <https://reviews.llvm.org/D153963#4511653>, @antoniofrighetto wrote:

> @goldstein.w.n, looking at the CI failure <https://buildkite.com/llvm-project/premerge-checks/builds/165237> on Windows, it seems like that for test `sub_select_sext_op_swapped_non_const_args` it expects `sub i6 0, [[ARGF]]` to be the first instruction, as opposed to the one on Linux, where that sub appears as second instruction. That may be the reason why FileCheck fails.

Oh, I wouldn't worry about that. I don't think the CI for phabricator is really used. AFAIK we only do post commit testing for LLVM (atlthough some sub projects do pre commit testing).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153963/new/

https://reviews.llvm.org/D153963



More information about the llvm-commits mailing list