[PATCH] D155638: [llvm-reduce] Reduce function calling convention

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceFunctionBodies.cpp:46
+  case CallingConv::C:
+  case CallingConv::AMDGPU_CS_Chain:
+    return false;
----------------
aeubanks wrote:
> aeubanks wrote:
> > I think this should be a list of CCs to opt-out, rather than opt-in to calling convention reduction since it really should be fine to reduce them to CCC in terms of legality.
> > 
> > For the amdgpu entry-point concerns, that's the point of the interestingness test?
> oh I forgot to ask the initial question, if you do want to opt out some CCs, which ones do you want to opt out?
I think opt-in is basically always a better system, especially for target stuff (which is what any unlisted CC is going to be)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155638/new/

https://reviews.llvm.org/D155638