[PATCH] D155638: [llvm-reduce] Reduce function calling convention
Arthur Eubanks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 18 13:38:30 PDT 2023
aeubanks added inline comments.
================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceFunctionBodies.cpp:46
+ case CallingConv::C:
+ case CallingConv::AMDGPU_CS_Chain:
+ return false;
----------------
I think this should be a list of CCs to opt-out, rather than opt-in to calling convention reduction since it really should be fine to reduce them to CCC in terms of legality.
For the amdgpu entry-point concerns, that's the point of the interestingness test?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155638/new/
https://reviews.llvm.org/D155638
More information about the llvm-commits
mailing list